Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for FSD without waves, clarify documentation #409

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Add warning for FSD without waves, clarify documentation #409

merged 7 commits into from
Oct 20, 2022

Conversation

lettie-roach
Copy link
Contributor

@lettie-roach lettie-roach commented Oct 14, 2022 •
edited by eclare108213
Loading

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Add warning for FSD without waves, clarify documentation
  • Developer(s):
    Lettie Roach
  • Suggest PR reviewers from list in the column to the right.
    @eclare108213 @apcraig
  • Please copy the PR test results link or provide a summary of testing completed below.
    None
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

(@eclare108213 edited to to remove spaces from the checkboxes)

eclare108213
eclare108213 reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged as soon as we make the new wave forcing file available, along with the CICE changes in CICE-Consortium/CICE#775.

@apcraig
Copy link
Contributor

apcraig commented Oct 18, 2022

This all looks pretty straight-forward, not sure where a new file comes in. I think this can be merged as is unless there are other things to do.

@lettie-roach
Copy link
Contributor Author

Is there already a wave spectrum file for a whole year available? If so, then no extra file is needed. Cheyenne is down at the moment so I can't check what's in the ocn_data_dir

@apcraig
Copy link
Contributor

apcraig commented Oct 19, 2022

The file we're using now for testing is ww3.20100101_efreq_remapgx3.nc. That file seems to have 6 hourly data for 1 day.

	time = UNLIMITED ; // (4 currently)
		time:units = "days since 1990-01-01 00:00:00" ;
 time = 7305, 7305.25, 7305.5, 7305.75 ;

@apcraig apcraig merged commit b77d51c into CICE-Consortium:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

@eclare108213 eclare108213 Awaiting requested review from eclare108213

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lettie-roach @apcraig @eclare108213